fix: propagate Azure OpenAI configs to the SlideDeckAI class and update tests

.vscode/settings.json

@@ -0,0 +1,4 @@
+{
+    "snyk.advanced.organization": "457f0b78-1951-4a11-b535-632990ba967e",
+    "snyk.advanced.autoSelectOrganization": true
+}

app.py

@@ -100,8 +100,8 @@ def are_all_inputs_valid(
     provider: str,
     selected_model: str,
     user_key: str,
-    azure_deployment_url: str = '',
-    azure_endpoint_name: str = '',
+    azure_endpoint_url: str = '',
+    azure_deployment_name: str = '',
     azure_api_version: str = '',
 ) -> bool:
     """Validate user input and LLM selection.
@@ -111,8 +111,8 @@ def are_all_inputs_valid(
         provider: The LLM provider.
         selected_model: Name of the model.
         user_key: User-provided API key.
-        azure_deployment_url: Azure OpenAI deployment URL.
-        azure_endpoint_name: Azure OpenAI model endpoint.
+        azure_endpoint_url: Azure OpenAI endpoint URL.
+        azure_deployment_name: Azure OpenAI deployment name.
         azure_api_version: Azure OpenAI API version.
 
     Returns:
@@ -135,8 +135,8 @@ def are_all_inputs_valid(
         provider,
         selected_model,
         user_key,
-        azure_endpoint_name,
-        azure_deployment_url,
+        azure_endpoint_url,
+        azure_deployment_name,
         azure_api_version,
     ):
         handle_error(
@@ -277,15 +277,6 @@ with st.sidebar:
             disabled=bool(default_api_key),
         )
 
-        # If a model was updated in the sidebar, make sure to update it in the SlideDeckAI instance
-        if SLIDE_GENERATOR in st.session_state and llm_provider_to_use:
-            try:
-                st.session_state[SLIDE_GENERATOR].set_model(llm_provider_to_use, api_key_token)
-            except Exception as e:
-                logger.error('Failed to update model on existing SlideDeckAI: %s', e)
-                # If updating fails, drop the stored instance so a new one is created
-                st.session_state.pop(SLIDE_GENERATOR, None)
-
         # Additional configs for Azure OpenAI
         with st.expander('**Azure OpenAI-specific configurations**'):
             azure_endpoint = st.text_input(
@@ -307,6 +298,21 @@ with st.sidebar:
                 value='2024-05-01-preview',
             )
 
+        # If a model was updated in the sidebar, make sure to update it in the SlideDeckAI instance
+        if SLIDE_GENERATOR in st.session_state and llm_provider_to_use:
+            try:
+                st.session_state[SLIDE_GENERATOR].set_model(
+                    llm_provider_to_use,
+                    api_key=api_key_token,
+                    azure_endpoint_url=azure_endpoint,
+                    azure_deployment_name=azure_deployment,
+                    azure_api_version=api_version,
+                )
+            except Exception as e:
+                logger.error('Failed to update model on existing SlideDeckAI: %s', e)
+                # If updating fails, drop the stored instance so a new one is created
+                st.session_state.pop(SLIDE_GENERATOR, None)
+
     # Make slider with initial values
     page_range_slider = st.slider(
         'Specify a page range for the uploaded PDF file (if any):',
@@ -419,6 +425,9 @@ def set_up_chat_ui():
                     st.session_state.get('start_page'),
                     st.session_state.get('end_page'),
                 ),
+                azure_endpoint_url=azure_endpoint,
+                azure_deployment_name=azure_deployment,
+                azure_api_version=api_version,
             )
             st.session_state[SLIDE_GENERATOR] = slide_generator
 

src/slidedeckai/core.py

@@ -78,6 +78,9 @@ class SlideDeckAI:
         pdf_path_or_stream=None,
         pdf_page_range=None,
         template_idx: int = 0,
+        azure_endpoint_url: str = '',
+        azure_deployment_name: str = '',
+        azure_api_version: str = '',
     ):
         """Initialize the SlideDeckAI object.
 
@@ -88,6 +91,9 @@ class SlideDeckAI:
             pdf_path_or_stream: The path to a PDF file or a file-like object.
             pdf_page_range: A tuple representing the page range to use from the PDF file.
             template_idx: The index of the PowerPoint template to use.
+            azure_endpoint_url: Azure OpenAI endpoint URL (required when using Azure provider).
+            azure_deployment_name: Azure OpenAI deployment name (required when using Azure provider).
+            azure_api_version: Azure OpenAI API version (required when using Azure provider).
 
         Raises:
             ValueError: If the model name is not in VALID_MODELS.
@@ -105,6 +111,9 @@ class SlideDeckAI:
         # Validate template_idx is within valid range
         num_templates = len(GlobalConfig.PPTX_TEMPLATE_FILES)
         self.template_idx: int = template_idx if 0 <= template_idx < num_templates else 0
+        self.azure_endpoint_url: str = azure_endpoint_url
+        self.azure_deployment_name: str = azure_deployment_name
+        self.azure_api_version: str = azure_api_version
         self.chat_history = ChatMessageHistory()
         self.last_response = None
         logger.info('Using model: %s', model)
@@ -124,6 +133,9 @@ class SlideDeckAI:
             model=llm_name,
             max_new_tokens=gcfg.get_max_output_tokens(self.model),
             api_key=self.api_key,
+            azure_endpoint_url=self.azure_endpoint_url,
+            azure_deployment_name=self.azure_deployment_name,
+            azure_api_version=self.azure_api_version,
         )
 
     def _get_prompt_template(self, is_refinement: bool) -> str:
@@ -256,12 +268,22 @@ class SlideDeckAI:
 
         return path
 
-    def set_model(self, model_name: str, api_key: str | None = None):
-        """Set the LLM model (and API key) to use.
+    def set_model(
+        self,
+        model_name: str,
+        api_key: str | None = None,
+        azure_endpoint_url: str | None = None,
+        azure_deployment_name: str | None = None,
+        azure_api_version: str | None = None,
+    ):
+        """Set the LLM model (and optionally API key / Azure credentials) to use.
 
         Args:
             model_name: The name of the model to use.
             api_key: The API key for the LLM provider.
+            azure_endpoint_url: Azure OpenAI endpoint URL.
+            azure_deployment_name: Azure OpenAI deployment name.
+            azure_api_version: Azure OpenAI API version.
 
         Raises:
             ValueError: If the model name is not in VALID_MODELS.
@@ -271,8 +293,14 @@ class SlideDeckAI:
                 f'Invalid model name: {model_name}. Must be one of: {", ".join(VALID_MODEL_NAMES)}.'
             )
         self.model = model_name
-        if api_key:
+        if api_key is not None:
             self.api_key = api_key
+        if azure_endpoint_url is not None:
+            self.azure_endpoint_url = azure_endpoint_url
+        if azure_deployment_name is not None:
+            self.azure_deployment_name = azure_deployment_name
+        if azure_api_version is not None:
+            self.azure_api_version = azure_api_version
         logger.debug('Model set to: %s', model_name)
 
     def set_template(self, idx):

tests/unit/test_core.py

@@ -18,6 +18,8 @@ from .test_utils import (
 with patch('transformers.BertTokenizer', patch_bert_tokenizer()):
     from slidedeckai.core import SlideDeckAI, _process_llm_chunk, _stream_llm_response
 
+from slidedeckai.global_config import GlobalConfig
+
 
 @pytest.fixture
 def mock_env():
@@ -312,3 +314,110 @@ def test_topic_reset(slide_deck_ai):
     """Test that topic is retained after reset."""
     slide_deck_ai.reset()
     assert slide_deck_ai.topic == ''
+
+
+def test_slide_deck_ai_init_azure_credentials():
+    """Test that SlideDeckAI stores Azure credentials provided at init time.
+
+    Regression test: previously, SlideDeckAI had no Azure params, so credentials
+    collected in the UI sidebar were silently dropped and never reached LiteLLM.
+    """
+    sda = SlideDeckAI(
+        model='[az]azure/open-ai',
+        topic='AI',
+        api_key='valid-key-12345',
+        azure_endpoint_url='https://test.openai.azure.com/',
+        azure_deployment_name='my-deployment',
+        azure_api_version='2024-05-01-preview',
+    )
+    assert sda.azure_endpoint_url == 'https://test.openai.azure.com/'
+    assert sda.azure_deployment_name == 'my-deployment'
+    assert sda.azure_api_version == '2024-05-01-preview'
+
+
+@mock.patch('slidedeckai.core.llm_helper.get_provider_model')
+@mock.patch('slidedeckai.core.llm_helper.get_litellm_llm')
+def test_initialize_llm_azure_passes_credentials(mock_get_llm, mock_get_provider):
+    """Test that _initialize_llm() forwards Azure credentials to get_litellm_llm().
+
+    This is the core regression test: without the fix, _initialize_llm() called
+    get_litellm_llm() without azure_* params, causing a ValueError at stream time.
+    """
+    mock_get_provider.return_value = (GlobalConfig.PROVIDER_AZURE_OPENAI, 'azure/open-ai')
+    mock_get_llm.return_value = mock.Mock()
+
+    sda = SlideDeckAI(
+        model='[az]azure/open-ai',
+        topic='AI',
+        api_key='valid-key-12345',
+        azure_endpoint_url='https://test.openai.azure.com/',
+        azure_deployment_name='my-deployment',
+        azure_api_version='2024-05-01-preview',
+    )
+    sda._initialize_llm()
+
+    mock_get_llm.assert_called_once_with(
+        provider=GlobalConfig.PROVIDER_AZURE_OPENAI,
+        model='azure/open-ai',
+        max_new_tokens=mock.ANY,
+        api_key='valid-key-12345',
+        azure_endpoint_url='https://test.openai.azure.com/',
+        azure_deployment_name='my-deployment',
+        azure_api_version='2024-05-01-preview',
+    )
+
+
+@mock.patch.dict(
+    'slidedeckai.core.GlobalConfig.VALID_MODELS',
+    {
+        '[az]azure/open-ai': {'description': 'azure', 'max_new_tokens': 8192, 'paid': True},
+    },
+)
+def test_set_model_updates_azure_credentials():
+    """Test that set_model() updates Azure credentials when provided."""
+    sda = SlideDeckAI(
+        model='[az]azure/open-ai',
+        topic='AI',
+        api_key='old-key-12345',
+        azure_endpoint_url='https://old.openai.azure.com/',
+        azure_deployment_name='old-deployment',
+        azure_api_version='2024-02-01',
+    )
+
+    sda.set_model(
+        '[az]azure/open-ai',
+        api_key='new-key-12345',
+        azure_endpoint_url='https://new.openai.azure.com/',
+        azure_deployment_name='new-deployment',
+        azure_api_version='2024-05-01-preview',
+    )
+
+    assert sda.api_key == 'new-key-12345'
+    assert sda.azure_endpoint_url == 'https://new.openai.azure.com/'
+    assert sda.azure_deployment_name == 'new-deployment'
+    assert sda.azure_api_version == '2024-05-01-preview'
+
+
+@mock.patch.dict(
+    'slidedeckai.core.GlobalConfig.VALID_MODELS',
+    {
+        '[az]azure/open-ai': {'description': 'azure', 'max_new_tokens': 8192, 'paid': True},
+    },
+)
+def test_set_model_preserves_azure_credentials_when_not_provided():
+    """Test that set_model() keeps existing Azure credentials when None is passed."""
+    sda = SlideDeckAI(
+        model='[az]azure/open-ai',
+        topic='AI',
+        api_key='valid-key-12345',
+        azure_endpoint_url='https://test.openai.azure.com/',
+        azure_deployment_name='my-deployment',
+        azure_api_version='2024-05-01-preview',
+    )
+
+    # Call set_model without Azure params — existing values must be preserved
+    sda.set_model('[az]azure/open-ai')
+
+    assert sda.azure_endpoint_url == 'https://test.openai.azure.com/'
+    assert sda.azure_deployment_name == 'my-deployment'
+    assert sda.azure_api_version == '2024-05-01-preview'

tests/unit/test_llm_helper.py

@@ -259,3 +259,60 @@ def test_stream_litellm_completion_message_format(mock_litellm):
 
     assert result == ['Alternative format']
     mock_litellm.completion.assert_called_once()
+
+
+def test_stream_litellm_completion_azure_missing_deployment():
+    """Test that stream_litellm_completion raises ValueError when Azure deployment name is empty.
+
+    This is the precise condition that caused the runtime error when Azure OpenAI was selected
+    but credentials were not propagated through SlideDeckAI._initialize_llm().
+    """
+    messages = [{'role': 'user', 'content': 'Test'}]
+    with pytest.raises(ValueError, match='Azure deployment name is required'):
+        list(
+            stream_litellm_completion(
+                provider=GlobalConfig.PROVIDER_AZURE_OPENAI,
+                model='gpt-4',
+                messages=messages,
+                max_tokens=100,
+                api_key='valid-key-12345',
+                azure_endpoint_url='https://test.openai.azure.com/',
+                azure_deployment_name='',  # Empty — the missing credential
+                azure_api_version='2024-05-01-preview',
+            )
+        )
+
+
+@patch('slidedeckai.helpers.llm_helper.stream_litellm_completion')
+def test_get_litellm_llm_azure_passes_credentials(mock_stream):
+    """Test that get_litellm_llm forwards Azure credentials to stream_litellm_completion.
+
+    Regression test: SlideDeckAI._initialize_llm() previously called get_litellm_llm()
+    without Azure params, so LiteLLMWrapper was created with empty strings and the
+    deployment-name check in stream_litellm_completion raised a ValueError at call time.
+    """
+    mock_stream.return_value = iter(['Azure response'])
+
+    llm = get_litellm_llm(
+        provider=GlobalConfig.PROVIDER_AZURE_OPENAI,
+        model='gpt-4',
+        max_new_tokens=100,
+        api_key='valid-key-12345',
+        azure_endpoint_url='https://test.openai.azure.com/',
+        azure_deployment_name='my-deployment',
+        azure_api_version='2024-05-01-preview',
+    )
+
+    result = list(llm.stream('Hello'))
+    assert result == ['Azure response']
+
+    mock_stream.assert_called_once_with(
+        provider=GlobalConfig.PROVIDER_AZURE_OPENAI,
+        model='gpt-4',
+        messages=[{'role': 'user', 'content': 'Hello'}],
+        max_tokens=100,
+        api_key='valid-key-12345',
+        azure_endpoint_url='https://test.openai.azure.com/',
+        azure_deployment_name='my-deployment',
+        azure_api_version='2024-05-01-preview',
+    )